rhtyd commented on issue #2697: agent: Avoid sudo, renew certificates assuming root URL: https://github.com/apache/cloudstack/pull/2697#issuecomment-395676192 The result posting failed due to backend error, I'll put the results manually: `[root@pr2697-t2745-kvm-centos7-marvin marvin]# python tools/xunit-reader.py MarvinLogs/` Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 247.64 | test_privategw_acl.py test_04_extract_template | `Failure` | 128.44 | test_templates.py I manually checked, LGTM the tests run on it including tests relevant to CA/cert/security changes: ``` Tests issuance of a certificate ... === TestName: test_issue_certificate_with_csr | Status : SUCCESS === ok Tests issuance of a certificate ... === TestName: test_issue_certificate_without_csr | Status : SUCCESS === ok Tests the ca certificate ... === TestName: test_list_ca_certificate | Status : SUCCESS === ok Tests default ca providers list ... === TestName: test_list_ca_providers | Status : SUCCESS === ok Tests certificate provisioning ... === TestName: test_provision_certificate | Status : SUCCESS === ok Tests certificate revocation ... === TestName: test_revoke_certificate | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 6 tests in 21.122s OK Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS === ok Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok Test NFS Version on Secondary Storage mounted properly on SSVM ... SKIP: No NFS version provided in test data ---------------------------------------------------------------------- Ran 11 tests in 436.613s ``` I'll merge this based on above and code reviews.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
