rafaelweingartner commented on a change in pull request #2706: packaging: use 
libuuid x86_64 package for cloudstack-common
URL: https://github.com/apache/cloudstack/pull/2706#discussion_r195387614
 
 

 ##########
 File path: 
tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
 ##########
 @@ -78,12 +78,7 @@ function install_packages() {
   apt-get clean
   apt-get autoclean
 
-  #32 bit architecture support:: not required for 32 bit template
-  if [ "${arch}" != "i386" ]; then
-    dpkg --add-architecture i386
-    apt-get update
-    ${apt_get} install links:i386 libuuid1:i386 libc6:i386
-  fi
+  ${apt_get} install links
 
 Review comment:
   I mean, can't we simply do the following?
   ```
   mkdir /lib/x86_64-linux-gnu/
   ln -s /lib/x86_64-linux-gnu/libuuid.so.1 /lib/i386-linux-gnu/libuuid.so.1
   ln -s /lib/x86_64-linux-gnu/libc.so.6 /lib/i386-linux-gnu/libc.so.6
   ```
   
   The libraries are already in the 64bits system when we install the "links" 
for 64bits. The problem is that they are in a different path that `vhd-util` 
does not know.
   
   If we create the symbolic links, we would have the following then:
   ```
   root@debian:~# ls -lah /lib/i386-linux-gnu/
   lrwxrwxrwx  1 root root   31 Jun 14 08:25 libc.so.6 -> 
/lib/x86_64-linux-gnu/libc.so.6
   lrwxrwxrwx  1 root root   34 Jun 14 08:24 libuuid.so.1 -> 
/lib/x86_64-linux-gnu/libuuid.so.1
   ```
   
   Would this work?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to