rafaelweingartner commented on a change in pull request #2743:
CLOUDSTACK-10380: Fix startvm giving another pw after pw reset
URL: https://github.com/apache/cloudstack/pull/2743#discussion_r203399511
##########
File path: server/src/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -703,7 +703,14 @@ public boolean savePassword(final Network network, final
NicProfile nic, final V
// save the password in DB
for (final VirtualRouter router : routers) {
if (router.getState() == State.Running) {
- return networkTopology.savePasswordToRouter(network, nic,
uservm, router);
+ final boolean result =
networkTopology.savePasswordToRouter(network, nic, uservm, router);
+ if (result) {
+ // Explicit password reset, while VM hasn't generated a
password yet.
+ final UserVmVO userVmVO = _userVmDao.findById(vm.getId());
+ userVmVO.setUpdateParameters(false);
Review comment:
What does this `updateParameters` means in the `userVmVo` object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
