rafaelweingartner commented on a change in pull request #2756: fix 
provisionCertificate api returns NPE when 'reconnect' parameter is true
URL: https://github.com/apache/cloudstack/pull/2756#discussion_r203736512
 
 

 ##########
 File path: 
engine/orchestration/src/main/java/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
 ##########
 @@ -368,9 +368,10 @@ public void reconnect(final long hostId) throws 
CloudRuntimeException, AgentUnav
         if (result == null) {
             super.reconnect(hostId);
 
 
 Review comment:
   Instead of adding an `else` block and then an `if` nested, what about simply 
using a `return;` statement here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to