khos2ow commented on a change in pull request #2762: Make HTTP handler of
embedded server to be configured
URL: https://github.com/apache/cloudstack/pull/2762#discussion_r204491504
##########
File path: client/src/main/java/org/apache/cloudstack/ServerDaemon.java
##########
@@ -163,11 +171,13 @@ public void start() throws Exception {
httpConfig.setSendDateHeader(false);
// HTTP Connector
- final ServerConnector httpConnector = new ServerConnector(server, new
HttpConnectionFactory(httpConfig));
- httpConnector.setPort(httpPort);
- httpConnector.setHost(bindInterface);
- httpConnector.setIdleTimeout(30000);
- server.addConnector(httpConnector);
+ if (httpEnable) {
+ final ServerConnector httpConnector = new ServerConnector(server,
new HttpConnectionFactory(httpConfig));
Review comment:
I don't see any benefit to do so. It's an one time execution, why do you
think extraction would be useful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
