rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r205416950
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -150,4 +164,74 @@ public void revokeDirectIpv6Address(long networkId,
String ip6Address) {
_ipv6Dao.remove(ip.getId());
}
}
+
+ @Override
+ public String allocateGuestIpv6(Network network, String requestedIpv6)
throws InsufficientAddressCapacityException {
+ return acquireGuestIpv6Address(network, requestedIpv6);
+ }
+
+ @Override
+ @DB
+ public String acquireGuestIpv6Address(Network network, String
requestedIpv6) throws InsufficientAddressCapacityException {
+ if (!_networkModel.isIP6AddressAvailableInNetwork(network.getId())) {
Review comment:
Do you validate somewhere else if the IP is valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
