ernjvr opened a new pull request #2784: insert plugin css files before custom.css file URL: https://github.com/apache/cloudstack/pull/2784 ## Description <!--- Describe your changes in detail --> In the index.html file, the reference to the custom.css file is made on the last line of the <head> tag. The plugins.js file appends a list of CSS files to the <head> tag dynamically, consequently placing them after the custom.css file and overriding it. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> Expected Behaviour: The plugins.js file must insert the list of CSS files before the custom.css file so that it does not get overridden. Actual Behaviour: The plugins.js file appends a list of CSS files to the <head> tag dynamically, consequently placing them after the custom.css file and overriding it. To Reproduce: Log in to the Cloudstack UI using your favourite browser. Use your browser's development tool to view the HTML elements of the index.html loaded in memory. Expand the <head> element and review the list of CSS <link> elements. Notice that the list of plugins CSS files is appended after the custom.css file. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Screenshots (if appropriate):  ## How Has This Been Tested? Manually (See screenshot above) Log in to the Cloudstack UI using your favourite browser. Use your browser's development tool to view the HTML elements of the index.html loaded in memory. Expand the <head> element and review the list of CSS <link> elements. Notice that the list of plugins CSS files is inserted before the custom.css file. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> Environment: CloudStack version 4.11, KVM hypervisor. <!-- see how your change affects other areas of the code, etc. --> ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
