[GitHub] rafaelweingartner commented on a change in pull request #2787: Fix wizards (new instance and new zone) div width problem in Chrome

Thu, 02 Aug 2018 13:37:18 -0700 

rafaelweingartner commented on a change in pull request #2787: Fix wizards (new 
instance and new zone) div width problem in Chrome
URL: https://github.com/apache/cloudstack/pull/2787#discussion_r207364228
 
 

 ##########
 File path: ui/scripts/ui-custom/instanceWizard.js
 ##########
 @@ -1359,18 +1359,18 @@
                     $wizard.find('div.data-disk-offering 
span.custom-disk-size').html(_s(old));
                 });
 
+                var wizardWidth = 950;
+                if($.browser.mozilla){
+                    wizardWidth = 896;
+                }
                 
                 var wizardDialog = $wizard.dialog({
                     title: _l('label.vm.add'),
-                    width: 896,
+                    width: wizardWidth,
 
 Review comment:
   This is the picture from my chrome using the code of this PR:
   
   Add zone:
   
![image](https://user-images.githubusercontent.com/4129005/43609348-1ca0c0aa-967a-11e8-8a0a-fffe30bccd57.png)
   
   Add instance:
   
![image](https://user-images.githubusercontent.com/4129005/43609367-2c0145ec-967a-11e8-9d4d-8f0d5444d1bc.png)
   
   I am not sure if the problem is somewhere in the browser or somehow in the 
O.S.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to