lhmachado commented on a change in pull request #2806: ajusting dict to pass on
if tests later on code, in this way arping i…
URL: https://github.com/apache/cloudstack/pull/2806#discussion_r211603318
##########
File path: systemvm/debian/opt/cloud/bin/merge.py
##########
@@ -236,7 +236,7 @@ def processCLItem(self, num, nw_type):
if('localgw' in self.qFile.data['cmd_line']):
dp['gateway'] = self.qFile.data['cmd_line']['localgw']
else:
- dp['gateway'] = 'None'
+ dp['gateway'] = ''
Review comment:
@wido later on code, there is a string literal concatenation, so if we use
None (Type), will raise an "TypeError: cannot concatenate 'str' and 'NoneType'
objects".
In python the '' also represent emptyness in if steatements, for this reason
in this particular case i`ve used '' instead None (type) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
