DaanHoogland commented on a change in pull request #2806: ajusting dict to pass
on if tests later on code, in this way arping i…
URL: https://github.com/apache/cloudstack/pull/2806#discussion_r211645118
##########
File path: systemvm/debian/opt/cloud/bin/merge.py
##########
@@ -236,7 +236,7 @@ def processCLItem(self, num, nw_type):
if('localgw' in self.qFile.data['cmd_line']):
dp['gateway'] = self.qFile.data['cmd_line']['localgw']
else:
- dp['gateway'] = 'None'
+ dp['gateway'] = ''
Review comment:
ok, good point. So either this (less code) or a check on the gateway later
to prevent the faulty concat. I can live with this solution. @wido?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
