rhtyd commented on a change in pull request #2824: Fix SystemVMs running in Xen
HVM mode are not configured (#2760)
URL: https://github.com/apache/cloudstack/pull/2824#discussion_r213955653
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -35,8 +35,15 @@ log_it() {
}
hypervisor() {
- local try=$([ -x /usr/sbin/virt-what ] && virt-what | tail -1)
- [ "$try" != "" ] && echo $try && return 0
+ [ -x /usr/sbin/virt-what ] && local facts=( $(virt-what) )
+ if [ "$facts" != "" ]; then
+ # Xen HVM is recognized as Hyperv when Viridian extensions are enabled
+ if [ "${facts[-1]}" == "xen-domU" ] && [ "${facts[0]}" == "hyperv" ]; then
Review comment:
We have support for `hyperv`, it may be wrong to return 'xen-hvm' when fact
is hyperv? I'm not sure how this may affect hyperv.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
