rafaelweingartner commented on a change in pull request #2500: Restrict the number of managed clustered file systems per compute cluster URL: https://github.com/apache/cloudstack/pull/2500#discussion_r214222811
########## File path: engine/components-api/src/main/java/com/cloud/storage/StorageUtil.java ########## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package com.cloud.storage; + +import com.cloud.dc.ClusterVO; +import com.cloud.dc.dao.ClusterDao; +import com.cloud.host.HostVO; +import com.cloud.host.dao.HostDao; +import com.cloud.hypervisor.Hypervisor; +import com.cloud.storage.dao.VolumeDao; +import com.cloud.vm.VMInstanceVO; +import com.cloud.vm.dao.VMInstanceDao; + +import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao; +import org.apache.cloudstack.storage.datastore.db.StoragePoolVO; +import org.apache.commons.collections.CollectionUtils; + +import java.util.List; +import javax.inject.Inject; + +public class StorageUtil { + @Inject private ClusterDao clusterDao; + @Inject private HostDao hostDao; + @Inject private PrimaryDataStoreDao storagePoolDao; + @Inject private VMInstanceDao vmInstanceDao; + @Inject private VolumeDao volumeDao; + + private Long getClusterId(Long hostId) { + if (hostId == null) { + return null; + } + + HostVO hostVO = hostDao.findById(hostId); + + if (hostVO == null) { + return null; + } + + return hostVO.getClusterId(); + } + + public boolean managedStoragePoolCanScale(StoragePool storagePool, Long clusterId, Long hostId) { Review comment: Can you provide a java documentation explaining the rationale behind this method? This can facilitate for people to understand what it does, and where it is used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
