rhtyd commented on a change in pull request #2840: Fix for Vmware full clones
update
URL: https://github.com/apache/cloudstack/pull/2840#discussion_r216755561
##########
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -1399,7 +1399,7 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
if (cloneSettingVO != null) {
if
(!cloneSettingVO.getCloneType().equals(cloneType.toString())) {
cloneSettingVO.setCloneType(cloneType.toString());
- _vmCloneSettingDao.update(cloneSettingVO.getVmId(),
cloneSettingVO);
+ _vmCloneSettingDao.update(cloneSettingVO.getId(),
cloneSettingVO);
Review comment:
Can you explore db related code, esp the *_details table and similar where
we update a row without them having an 'id' column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
