DaanHoogland commented on a change in pull request #2860: packaging: Fixes 
#2857 don't overwrite agent logrotate config
URL: https://github.com/apache/cloudstack/pull/2860#discussion_r219464475
 
 

 ##########
 File path: packaging/centos63/cloud.spec
 ##########
 @@ -574,7 +574,7 @@ pip install --upgrade 
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
 %attr(0755,root,root) %{_bindir}/%{name}-ssh
 %attr(0755,root,root) %{_sysconfdir}/init.d/%{name}-agent
 %attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}-agent-profile.sh
-%attr(0644,root,root) %{_sysconfdir}/logrotate.d/%{name}-agent
+%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}-agent
 
 Review comment:
   what happens on the initial install, @rhtyd ? did you check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to