rafaelweingartner commented on a change in pull request #2927: server: fix 
unwanted txn commit warning messages
URL: https://github.com/apache/cloudstack/pull/2927#discussion_r228129400
 
 

 ##########
 File path: server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
 ##########
 @@ -886,60 +886,54 @@ public Long doInTransaction(TransactionStatus status) {
 
     @DB
     protected long recalculateAccountResourceCount(final long accountId, final 
ResourceType type) {
-        Long newCount = Transaction.execute(new TransactionCallback<Long>() {
-                @Override
-                public Long doInTransaction(TransactionStatus status) {
-                    Long newCount = null;
-                    lockAccountAndOwnerDomainRows(accountId, type);
 
 Review comment:
   Aren't these aggregated values (of resources usage/allocated) used to 
control the deployment of new resources?
   
   I thought they were, that is why I thought it is important to have them 
consistent at all time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to