rhtyd commented on a change in pull request #2977: Defer was broken in VR
because of json name change. Fix if statement.
URL: https://github.com/apache/cloudstack/pull/2977#discussion_r228817465
##########
File path: systemvm/debian/opt/cloud/bin/update_config.py
##########
@@ -52,7 +52,7 @@ def process_file():
qf.setFile(sys.argv[1])
qf.load(None)
# These can be safely deferred, dramatically speeding up loading times
- if not (os.environ.get('DEFER_CONFIG', False) and sys.argv[1] in
('vm_dhcp_entry.json', 'vm_metadata.json')):
+ if not (os.environ.get('DEFER_CONFIG', False) and ('vm_dhcp_entry.json' in
sys.argv[1] or 'vm_metadata.json' in sys.argv[1])):
Review comment:
I'm okay with this changes, however this can be changed to `startswith`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
