DaanHoogland commented on a change in pull request #2980: [4.11] Fix set
initial reservation on public IP ranges
URL: https://github.com/apache/cloudstack/pull/2980#discussion_r229189353
##########
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -3569,10 +3569,10 @@ public VlanVO doInTransaction(final TransactionStatus
status) {
}
// increment resource count for dedicated public ip's
_resourceLimitMgr.incrementResourceCount(vlanOwner.getId(),
ResourceType.public_ip, new Long(ips.size()));
- } else if (domain != null) {
+ } else if (domain != null && !forSystemVms) {
// This VLAN is domain-wide, so create a DomainVlanMapVO
entry
- //final DomainVlanMapVO domainVlanMapVO = new
DomainVlanMapVO(domain.getId(), vlan.getId());
- //_domainVlanMapDao.persist(domainVlanMapVO);
+ final DomainVlanMapVO domainVlanMapVO = new
DomainVlanMapVO(domain.getId(), vlan.getId());
Review comment:
the rest of the change seems trivial. I just wonder why these lines where
commented in the first place. Can you explain @nvazquez ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
