DaanHoogland commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r229193235
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -1675,6 +1737,64 @@ private SnapshotDetailsVO handleSnapshotDetails(long
csSnapshotId, String value)
return _snapshotDetailsDao.persist(snapshotDetails);
}
+ /**
Review comment:
this file is growing over 300 lines. Can we move the KVM live migration code
to a TacticalKVMMigrationAid class? (name just a suggestion)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
