rafaelweingartner commented on issue #3004: [Placeholder] Add new data motion strategy for KVM non managed storage live migrations URL: https://github.com/apache/cloudstack/pull/3004#issuecomment-436621395 I see your point here, but I do not think that this will help much. As I have seen you guys will change/modify similar chunks of code. For instance, in @GabrielBrascher's PR, he configures the `canHandle` method as final, and then creates an `internalCanHandle`. The first method assures that the `canHandle` for all of the subclass will always check if the target host is a KVM type, and then the subclasses will do their own thing with the `internalCanHandle`. This will already create conflicts for your PR. I am not saying that the approach used by Gabriel is bad, quite the opposite, it is using properly object orientation, which is most of the times overlooked in ACS code base where people are always tending to copy and paste things. Therefore, I think we should work to move @GabrielBrascher's PR as fast as possible, and then we help you to adapt to that context.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
