wido commented on a change in pull request #3018: Prevent error on GroupAnswers
on VR creation
URL: https://github.com/apache/cloudstack/pull/3018#discussion_r232639170
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
##########
@@ -524,15 +524,16 @@ def post_config_change(self, method):
CsHelper.execute("sudo ip route add throw " +
self.config.address().dbag['eth1'][0]['network'] + " table " + tableName + "
proto static")
# add 'defaul via gateway' rule in the device specific routing
table
- if "gateway" in self.address and self.address["gateway"] !=
"None":
+ if "gateway" in self.address and self.address["gateway"] and
self.address["gateway"] != "None":
Review comment:
Why do we check here on "None" as a String? And not None as you should in
Python?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
