DaanHoogland commented on a change in pull request #2848: Vmware offline 
migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233750458
 
 

 ##########
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java
 ##########
 @@ -192,4 +187,25 @@ public void execute() {
             throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
e.getMessage());
         }
     }
+
+    @Override
+    public String getSyncObjType() {
 
 Review comment:
   i can, but it will be not a little bit ;)
   tl;dr: limitting the number of jobs send to vmware.
   There is a mechanism to limit jobs. It checks in the sync phase of async 
jobs to see if the queue for those jobs exeeds a certain length. If so it 
return to the user to try again later. It can filter on type and entity, if it 
can get them. These methods are part of those mechs. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to