DaanHoogland commented on a change in pull request #3000: CLOUDSTACK-2998:
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r233754704
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String
bridgeName) {
return "";
}
- String [] _ifNamePatterns = {
+ static String [] ifNamePatterns = {
Review comment:
I agree with @rafaelweingartner , @GabrielBrascher , but it would be a
separate issue. I am not sure of the consequences so I would leave it out of
scope for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
