rhtyd commented on a change in pull request #3037: kvm: when untagged vxlan is
used, use the default guest/public bridge
URL: https://github.com/apache/cloudstack/pull/3037#discussion_r235056804
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
##########
@@ -233,8 +233,8 @@ private static boolean isInterface(final String fname) {
}
if (nic.getType() == Networks.TrafficType.Guest) {
- if ((nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan)
&& (vNetId != null) && (protocol != null) &&
(!vNetId.equalsIgnoreCase("untagged")) ||
- (nic.getBroadcastType() ==
Networks.BroadcastDomainType.Vxlan)) {
+ if ((nic.getBroadcastType() == Networks.BroadcastDomainType.Vlan
|| nic.getBroadcastType() == Networks.BroadcastDomainType.Vxlan)
+ && (vNetId != null) && (protocol != null) &&
(!vNetId.equalsIgnoreCase("untagged"))) {
Review comment:
I'll see what I can do soon, but busy this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
