rhtyd commented on a change in pull request #2997: Allow KVM VM live migration
with ROOT volume on file storage type
URL: https://github.com/apache/cloudstack/pull/2997#discussion_r236800412
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/MigrateKVMAsync.java
##########
@@ -51,19 +76,19 @@ public MigrateKVMAsync(final LibvirtComputingResource
libvirtComputingResource,
@Override
public Domain call() throws LibvirtException {
- long flags = 1 << 0;
+ long flags = VIR_MIGRATE_LIVE;
// set compression flag for migration, if libvirt version supports it
if (dconn.getLibVirVersion() >= 1000003) {
- flags |= 1 << 11;
+ flags += VIR_MIGRATE_COMPRESSED;
Review comment:
Understanding how flags work, the or was a more readable syntax for me than
the +=.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
