rhtyd commented on a change in pull request #2997: Allow KVM VM live migration
with ROOT volume on file storage type
URL: https://github.com/apache/cloudstack/pull/2997#discussion_r240986018
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -338,7 +382,7 @@ private String replaceStorage(String xmlDesc, Map<String,
MigrateCommand.Migrate
String path =
getPathFromSourceText(migrateStorage.keySet(), sourceText);
if (path != null) {
- MigrateCommand.MigrateDiskInfo migrateDiskInfo =
migrateStorage.remove(path);
+ MigrateCommand.MigrateDiskInfo migrateDiskInfo =
migrateStorage.get(path);
Review comment:
Was this a bug, to get and not remove a path. Can you send any bugfix PR
towards 4.11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
