dhlaluku commented on a change in pull request #2848: Vmware offline migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r237213354
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -1976,92 +1965,244 @@ public void storageMigration(final String vmUuid,
final StoragePool destPool) {
private void orchestrateStorageMigration(final String vmUuid, final
StoragePool destPool) {
final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
+ preStorageMigrationStateCheck(destPool, vm);
+
+ try {
+ if(s_logger.isDebugEnabled()) {
Review comment:
@rafaelweingartner @mike-tutkowski removed the log level check and formatted
the dynamic string prior to sending it as Log message
String msg = String.format("Offline migration of %s vm %s with volumes",
vm.getHypervisorType().toString(), vm.getInstanceName());
s_logger.debug(msg);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
