GabrielBrascher commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-446186655 @DaanHoogland thanks for pointing the inner class issue; I totally agree with you. I tried to go a bit further on my PR and fix this design; however the PR would be too large. The problem here is that such change will require a major refactoring on the stats collector architecture. It is not just about extracting the inner classes, we need to change their implementation to use object orientation in order to reduce the number of lines. My idea is to get back on this class and enhance it on +1 or +2 PRs. This way it will be easier for reviewers and for me to work on it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
