GabrielBrascher commented on issue #3078: Add influxdb to statscollector
URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-453159994
 
 
   Thanks for the input @rhtyd, I totally agree with you ;)
   
   On the PR description I stated that the Stats Collector will need to be 
competely refactored. This will get on my backlog of enhancing CloudStack 
codebase. 
   > Note: As the current stats collector supports only KVM, this extension 
supports only KVM. I am planning on enhance and refactor the StatsCollector 
architecture on the future. Due to the inner class structure, test case for 
some methods will not be implemented. On the future it will be necessary to 
refactor the whole StatsCOllector architecture and extract inner classes.
   
   I also discussed with @DaanHoogland about it 
https://github.com/apache/cloudstack/pull/3078#issuecomment-446186655.
   
   Now with the code for influxdb tested and stable, It will be easier to 
create a PR focusing just on refactoring the whole StatsCollector architecture.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to