GabrielBrascher commented on a change in pull request #3078: Add influxdb to
statscollector
URL: https://github.com/apache/cloudstack/pull/3078#discussion_r244318646
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -692,64 +722,59 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
if ((volumes == null) || (volumes.size()
== 0))
break;
VolumeVO volume = volumes.get(0);
- VmDiskStatisticsVO previousVmDiskStats =
-
_vmDiskStatsDao.findBy(userVm.getAccountId(), userVm.getDataCenterId(), vmId,
volume.getId());
+ VmDiskStatisticsVO previousVmDiskStats =
_vmDiskStatsDao.findBy(userVm.getAccountId(), userVm.getDataCenterId(), vmId,
volume.getId());
VmDiskStatisticsVO vmDiskStat_lock =
_vmDiskStatsDao.lock(userVm.getAccountId(), userVm.getDataCenterId(), vmId,
volume.getId());
- if ((vmDiskStat.getBytesRead() == 0) &&
(vmDiskStat.getBytesWrite() == 0) && (vmDiskStat.getIORead() == 0) &&
- (vmDiskStat.getIOWrite() == 0)) {
+ if ((vmDiskStat.getBytesRead() == 0) &&
(vmDiskStat.getBytesWrite() == 0) && (vmDiskStat.getIORead() == 0) &&
(vmDiskStat.getIOWrite() == 0)) {
Review comment:
@rafaelweingartner extracted and implemented tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
