rhtyd commented on a change in pull request #2847: CLOUDSTACK-10365: Change the
"getXXX" boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2847#discussion_r244577111
##########
File path:
engine/schema/src/main/java/com/cloud/offerings/NetworkOfferingVO.java
##########
@@ -485,17 +485,17 @@ public void setIsPersistent(Boolean isPersistent) {
}
@Override
- public boolean getIsPersistent() {
+ public boolean isPersistent() {
return isPersistent;
Review comment:
This cause the GC bug, our DB framework assumes that the attributes (map) is
created by a method interceptor so the name of the variable should not have the
'is', the name of the variable that related to a db table's column should be
something after removing get/is string prefix:
https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/SearchBase.java#L480
/cc @nvazquez @anuragaw @sh0wstopper @dhlaluku
https://github.com/apache/cloudstack/issues/2935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
