wido commented on a change in pull request #3113: kvm: Security Group 
enhancements and refactor old code
URL: https://github.com/apache/cloudstack/pull/3113#discussion_r245588687
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -35,11 +33,6 @@
 logpath = "/var/run/cloud/"        # FIXME: Logs should reside in 
/var/log/cloud
 
 Review comment:
   I am not sure what the implications might be.
   
   People might be parsing the files at that location, but also, if they are in 
/var/run/cloud they will be gone after a reboot (which is good!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to