rafaelweingartner commented on issue #1730: VMTemplateZone needs some love
URL: https://github.com/apache/cloudstack/pull/1730#issuecomment-453060255
 
 
   Yes, I did check while reviewing. 
   
   Here goes what I found at that time:
   The first method is not used, at least, I could not find a reference using 
"call hierarchy" in Eclipse. I did not try to dig into that, so I overlooked 
this fact.
   ```
   listByZoneId -- no reference found
   ```
   
   The second method is indeed used, but it makes sense to use only templates 
that have not been deleted yet.
   ```
   findByZoneTemplate(long, long) : VMTemplateZoneVO - 
com.cloud.storage.dao.VMTemplateZoneDao
        addTemplateToZone(VMTemplateVO, long) : long - 
com.cloud.storage.dao.VMTemplateDaoImpl
        associateCrosszoneTemplatesToZone(Long) : void - 
com.cloud.storage.StorageManagerImpl
        associateCrosszoneTemplatesToZone(long) : void - 
org.apache.cloudstack.storage.image.TemplateServiceImpl
        associateTemplatesToZone(long, long) : void - 
com.cloud.resource.SimulatorDiscoverer
        associateTemplatesToZone(long, long) : void - 
org.apache.cloudstack.storage.resource.SecondaryStorageDiscoverer
        associateTemplateToZone(long, Long) : void - 
org.apache.cloudstack.storage.image.TemplateServiceImpl
        delete(TemplateProfile) : boolean - 
com.cloud.baremetal.manager.BareMetalTemplateAdapter
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to