GabrielBrascher commented on a change in pull request #3122: Add back ability
to disable backup of snapshot to secondary
URL: https://github.com/apache/cloudstack/pull/3122#discussion_r248254705
##########
File path:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
##########
@@ -149,6 +149,17 @@ public long getPhysicalSize() {
return physicalSize;
}
+ @Override
+ public boolean markBackedUp() {
Review comment:
I am +1 on the @rafaelweingartner idea. Throwing a CloudRuntimeException
would be better than the boolean approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
