GabrielBrascher commented on a change in pull request #3143: Fix some LGTM
alerts
URL: https://github.com/apache/cloudstack/pull/3143#discussion_r250285065
##########
File path: api/src/main/java/com/cloud/deploy/DeployDestination.java
##########
@@ -78,6 +78,10 @@ public int hashCode() {
@Override
public boolean equals(Object obj) {
+ if (obj == null)
+ return false;
+ if (!(obj instanceof DeployDestination))
+ return false;
Review comment:
@1m2c3t4 can you please format the code to follow CloudStack code
conventions [1]?
From:
```
if (obj == null)
return false;
```
to:
```
if (obj == null) {
return false;
}
```
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
