dhlaluku commented on a change in pull request #3158: Allow users of all types
to create L2 networks
URL: https://github.com/apache/cloudstack/pull/3158#discussion_r252372671
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -1824,13 +1824,15 @@ public boolean deleteNetwork(long networkId, boolean
forced) {
// don't allow to delete system network
if (isNetworkSystem(network)) {
+ assert network != null;
Review comment:
Actually no since a null network object will throw a runtime exception
earlier than this point. I removed the redundant null assertion statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
