GabrielBrascher opened a new pull request #3162: Fix issue with verification of ipv4/ipv6 address. URL: https://github.com/apache/cloudstack/pull/3162 ## Description <!--- Describe your changes in detail --> Not possible to add secondary IPv4 or IPv6 address via UI. Having the following error: ``` TypeError: $.validator.methods[method] is undefined[Learn More] jquery.validate.js:777:6 check http://<IP>:8080/client/lib/jquery.validate.js:777:6 element http://<IP>:8080/client/lib/jquery.validate.js:492:10 onfocusout http://<IP>:8080/client/lib/jquery.validate.js:300:5 delegate http://<IP>:8080/client/lib/jquery.validate.js:423:6 dispatch http://<IP>:8080/client/lib/jquery.js:5182:23 add/elemData.handler http://<IP>:8080/client/lib/jquery.js:4991:15 trigger http://<IP>:8080/client/lib/jquery.js:8249:11 simulate http://<IP>:8080/client/lib/jquery.js:8318:7 handler http://<IP>:8080/client/lib/jquery.js:8352:9 ``` This was caused because of the ipv46address verification implemented in #2773; it was added on the jquery library (mea culpa). After upgrading the jQuery that verification was removed. I fixed by implementing it on the `sharedFunctions.js`. The same was applied by a customized ipv6 address verificiation that was implemented in the jQuery library. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): After the fix: ![screenshotfixacs](https://user-images.githubusercontent.com/5025148/52140981-78048980-263b-11e9-997c-0311421e50d4.jpg) ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services