DaanHoogland commented on a change in pull request #3170: NotImplemented as a 
local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255481242
 
 

 ##########
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##########
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
             case FAT:
                 return PreallocationType.Full;
             default:
-                throw new NotImplementedException();
+                throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   That is certainly an option, @rafaelweingartner . I had discussed with 
@nvazquez and he suggested the commons-lang NotImplementedException as it is 
loaded through the storage module anyhow. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to