GabrielBrascher opened a new pull request #3173: Mock Scanner, instead of scan 
the computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173
 
 
   This allows computers with Windows or MacOS to run the tests without 
scanning for `/proc/meminfo` path.
   
   At the class 
[MemStat.java](https://github.com/apache/cloudstack/blob/c496c84c6c727a84862cbbe2d870ff57939488b4/plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/MemStat.java#L71),
 the `refresh()` method (called in MemStat constructor) has the following lines:
   
   ```
   public void refresh() {
           File f = new File(MEMINFO_FILE);
           try (Scanner scanner = new Scanner(f,"UTF-8")) {
               parseFromScanner(scanner);
           } catch (FileNotFoundException ex) {
               throw new RuntimeException("File " + MEMINFO_FILE + " not 
found:" + ex.toString());
           }
   }
   ```
   When executing `Scanner scanner = new Scanner(f,"UTF-8")` it scans the file 
_MEMINFO_FILE_ (`/proc/meminfo`); however, if the OS running this test is not a 
Linux then it throws `FileNotFoundException`, failing the test.
   
   Thus, by Mocking the Scanner constructor, the `new Scanner(f,"UTF-8")` 
execution returns the desired Scanner.
   
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to