falcon78921 opened a new pull request #3174: scripts/network/ping: cleaned up 
code in baremetal_user_data.py
URL: https://github.com/apache/cloudstack/pull/3174
   ## Description
   <!--- Describe your changes in detail -->
   Cleaned up code in ``baremetal_user_data.py``. Updated string formatting
   to ``str.format()``. Introduced ``pathlib`` as an alternative to ``os.path``.
   Signed-off-by: James McClune <jmccl...@mcclunetechnologies.net>
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   ## Screenshots (if appropriate):
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
   <!-- see how your change affects other areas of the code, etc. -->
   Checked the syntax using PythonBuddy. If there are any errors, please let me 
   and I'll fix. :)
   <!-- Please read the 
 document -->

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to