GabrielBrascher commented on a change in pull request #3171: Keep iotune 
section in the VM's XML after live migration
URL: https://github.com/apache/cloudstack/pull/3171#discussion_r256075033
 
 

 ##########
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ##########
 @@ -346,13 +346,17 @@ String replaceIpForVNCInDescFile(String xmlDesc, final 
String target) {
         return xmlDesc;
     }
 
-    // Pass in a list of the disks to update in the XML (xmlDesc). Each disk 
passed in needs to have a serial number. If any disk's serial number in the
-    // list does not match a disk in the XML, an exception should be thrown.
-    // In addition to the serial number, each disk in the list needs the 
following info:
-    //   * The value of the 'type' of the disk (ex. file, block)
-    //   * The value of the 'type' of the driver of the disk (ex. qcow2, raw)
-    //   * The source of the disk needs an attribute that is either 'file' or 
'dev' as well as its corresponding value.
-    private String replaceStorage(String xmlDesc, Map<String, 
MigrateCommand.MigrateDiskInfo> migrateStorage)
+    /**
+     * Pass in a list of the disks to update in the XML (xmlDesc). Each disk 
passed in needs to have a serial number. If any disk's serial number in the
+     * list does not match a disk in the XML, an exception should be thrown.
+     * In addition to the serial number, each disk in the list needs the 
following info:
+     * <ul>
+     *  <li>The value of the 'type' of the disk (ex. file, block)
+     *  <li>The value of the 'type' of the driver of the disk (ex. qcow2, raw)
+     *  <li>The source of the disk needs an attribute that is either 'file' or 
'dev' as well as its corresponding value.
+     * </ul>
+     */
 
 Review comment:
   That is a good question @DaanHoogland. As the migration of VMs with volume 
in ceph does not happen in this execution flow, so far we have not experienced 
problems with that conditional. However, I do not know why that conditional is 
there as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to