GabrielBrascher commented on a change in pull request #3197: Fix XenServer
Security Groups 'vmops' script
URL: https://github.com/apache/cloudstack/pull/3197#discussion_r262507866
##########
File path: core/src/main/java/com/cloud/agent/api/SecurityGroupRulesCmd.java
##########
@@ -173,7 +173,7 @@ public String getSecIpsString() {
final StringBuilder sb = new StringBuilder();
final List<String> ips = getSecIps();
if (ips == null) {
- sb.append("0:");
+ sb.append("0;");
Review comment:
Yes, that would avoid future issues in case of an update on the
RULE_COMMAND_SEPARATOR. I will update it soon when having the other raised
points addressed as well. Thanks for pointing that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
