shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] 
server: offerings for specified domain(s) and zone(s) 
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r274941290
 
 

 ##########
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java
 ##########
 @@ -42,6 +43,13 @@
     @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
description = "name of the disk offering")
     private String diskOfferingName;
 
+    @Parameter(name = ApiConstants.ZONE_ID,
+            type = CommandType.UUID,
+            entityType = ZoneResponse.class,
+            description = "id of zone disk offering is associated with",
+            since = "4.13")
+    private Long zoneId;
 
 Review comment:
   @DaanHoogland List APIs are changed only for a single zone. Multiple domains 
and zones can be specified with create or update APIs.
   Single zone in list API is needed as when we create storage, network or 
deploy VM we select or specify a particular zone. Therefore we need to query 
those offerings which are available for that particular zone or domain(through 
calling account).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to