shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r274944268
##########
File path:
api/src/main/java/org/apache/cloudstack/api/response/NetworkOfferingResponse.java
##########
@@ -124,6 +123,22 @@
@Param(description = "true if network offering supports public access for
guest networks", since = "4.10.0")
private Boolean supportsPublicAccess;
+ @SerializedName(ApiConstants.DOMAIN_ID)
+ @Param(description = "the domain ID(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.")
Review comment:
Multiple domains are supported with a comma-separated list of domain IDs.
This is done to maintain backward compatibility and consistency.
ServiceOfferingResponse and DiskOfferingResponse already had a domainId
parameter and if an array of IDs would have been used instead of
comma-separated string it might have broken automation scripts for some.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
