rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more
states for attaching disk in allocated state
URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276172325
##########
File path: api/src/com/cloud/storage/Volume.java
##########
@@ -119,9 +120,12 @@ public String getDescription() {
s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(UploadInProgress, Event.OperationTimeout, UploadError, null));
s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(UploadError, Event.DestroyRequested, Destroy, null));
s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(UploadAbandoned, Event.DestroyRequested, Destroy, null));
- s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(Ready, Event.AttachRequested, Attaching, null));
- s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(Attaching, Event.OperationSucceeded, Ready, null));
- s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(Attaching, Event.OperationFailed, Ready, null));
+ s_fsm.addTransition(new StateMachine2.Transition<State,
Event>(Allocated, Event.AttachRequested, AttachingFromAllocated, null));
Review comment:
Let's keep this only and rest can follow the same, i.e. allow both Ready and
Allocated state volumes to go into Attaching state on the event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
