DagSonsteboSB opened a new issue #3287: Secondary storage pool 90pct limit ignored URL: https://github.com/apache/cloudstack/issues/3287 ##### ISSUE TYPE * Bug Report ##### COMPONENT NAME * Secondary storage pool / SSVM ##### CLOUDSTACK VERSION * Any ##### CONFIGURATION * Any ##### OS / ENVIRONMENT * N/A ##### SUMMARY * Secondary storage pools should in theory not be considered for template / volume / ISO / snapshot upload if percentage utilisation is > 90% * However if no other pool exist < 90% then the first available secondary pool will be chosen and the 90% utilisation limit ignored. * This results in secondary storage pools potentially filling up until copy process fails, potentially leading to data loss * In the following line secondary pools below 90% utilisation are returned: https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java#L155 * However if no secondary storage pool exists <90% then the first secondary storage pool is still picked: https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java#L160 ##### STEPS TO REPRODUCE * Create zone with single secondary pool and fill this to above 90% * Try to upload template / ISO / volume and observe this succeeding ##### EXPECTED RESULTS * Upload process should gracefully fail. ##### ACTUAL RESULTS * Upload process allows for upload to happen above 90% utilisation
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
