[GitHub] [cloudstack] bd2019us commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance

[GitBox]

bd2019us commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix 
String.replaceAll() to replace() for better performance
URL: https://github.com/apache/cloudstack/pull/3275#discussion_r279612124
 
 

 ##########
 File path: 
framework/ipc/src/main/java/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
 ##########
 @@ -109,7 +109,7 @@ public void scan() {
                     if (filePath != null) {
                         // WINDOWS HACK
                         if (filePath.indexOf("%20") > 0)
-                            filePath = filePath.replaceAll("%20", " ");
+                            filePath = filePath.replace("%20", " ");
 
 Review comment:
   We cannot since there does not exist an API to replace an `String` with a 
`char`. Therefore, I think it should be fine like it is. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services