kioie commented on issue #3293: Limit selecting of secondary storage with 90% utilization URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-487833694 > Simply returning `null` could possibly result in newer bugs. ( On a quick inspection it seems that the method consumers would not always check for null values ). > > I wonder if more testing scenarios than mentioned on the PR should be covered. Thoughts? I debated with the thought of editing the method consumers to handle null returns intrinsically, but I noticed in most cases (at least to the best of my knowledge) null returns are eventually handled by level 2 consumers. I'd be curious to try out other related test cases
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
