rafaelweingartner commented on a change in pull request #3312: 'sed -i' need
postfix on mac
URL: https://github.com/apache/cloudstack/pull/3312#discussion_r280384893
##########
File path: tools/apidoc/build-apidoc.sh
##########
@@ -61,8 +60,8 @@ set -e
cp "$thisdir"/*.java .
cp "$thisdir"/*.xsl .
sed -e 's,%API_HEADER%,All APIs,g' "$thisdir/generatetoc_header.xsl"
>generatetoc.xsl
- sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl
- sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatecommands.xsl
+ sed -i .bak "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl
Review comment:
What if we execute the commands at line 63 and 64 like the one in 62? Or,
maybe the other way around.
I mean, they do the same thing, but with different approaches. Therefore, it
might be interesting to maintain some consistency here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
