rafaelweingartner commented on a change in pull request #3312: 'sed -i' need
postfix on mac
URL: https://github.com/apache/cloudstack/pull/3312#discussion_r280391746
##########
File path: tools/apidoc/build-apidoc.sh
##########
@@ -61,8 +60,8 @@ set -e
cp "$thisdir"/*.java .
cp "$thisdir"/*.xsl .
sed -e 's,%API_HEADER%,All APIs,g' "$thisdir/generatetoc_header.xsl"
>generatetoc.xsl
- sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl
- sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatecommands.xsl
+ sed -i .bak "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl
Review comment:
I meant the following:
All of the commands are replacing "place holders" in the same file. However,
two of them are doing in line (via -i flag), whereas line 62 is replacing the
entire file (not using the -i flag and redirecting the output of the `sed` to a
file with the same name). I do not mind if we do in different commands the
replace, but we could at least try to use the same approach in all of them.
By approach here I mean the method, either inline or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
