webermaximilian92 opened a new pull request #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328 ## Description This PR is an SCSS-refactoring addition to PR: https://github.com/apache/cloudstack/pull/3307#issuecomment-491314203 <!--- Describe your changes in detail --> This enhances code-quality of scss code by - including tool-tasks like sass-lint-fix (autodetects scss lint warnings and fix them if possible) - adding jsbeautifyrc, that can be used by IDE extensions to unify scss code automatically - deleting old css files for IE7, that will no longer be in use today (almost 13 years old browser) - rethinking of old "custom.css"-style-file. (it's not beneficial to generate own custom css file anymore. The less css, the less server requests. Rather now any CSS code can be included inside custom.scss file and will be compiled at bottom of cloudstack3.css by compiler. - adding z-index variables to better organize treacherous interdependently z-index values. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? By running compilers and check build css code and by visiting the page with new css file. (This changes modify and unify the structure of css code only and deleting old unused code) All we have to check yet, is if cloudstack3.css includes any effective changes. It's very useful to reduce the diff to non whitespace changes here again:  <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
